Skip to content

Fix up bad commits included in the 0.5.3 release #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 17, 2021
Merged

Fix up bad commits included in the 0.5.3 release #105

merged 2 commits into from
Dec 17, 2021

Conversation

bsweeney
Copy link
Member

😞

@bsweeney
Restore accidentally removed logic from File::read
b82d702
@bsweeney
Read outlines even if the size is not set
c4946e7 
This populates the raw outline data, which prevents errors during font parsing.

partially addresses #104
@bsweeney bsweeney added this to the 0.5.4 milestone Dec 17, 2021
@bsweeney bsweeney changed the title Address incorrect commits included in the 0.5.3 release Fix up broken commits included in the 0.5.3 release Dec 17, 2021
bsweeney referenced this pull request Dec 17, 2021
@bsweeney
Use MBString functions for 8bit data read
baa890c 
Prevents issues with MBString overrides of standard PHP functions.
@bsweeney bsweeney changed the title Fix up broken commits included in the 0.5.3 release Fix up bad commits included in the 0.5.3 release Dec 17, 2021
@bsweeney bsweeney merged commit dd448ad into master Dec 17, 2021
@bsweeney bsweeney deleted the cleanup-0.5.3 branch December 17, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.4
Development

Successfully merging this pull request may close these issues.
1 participant
@bsweeney